View Change

1 comment:

• File configure.ac:

  • Patch Set #1, Line 40: [

    Don't we need to escape square brackets? […]

    It is written like that a few times in this configure.ac already, and it works as expected (configure --help output, tab completion). I'm not sure why it would be escaped like that in other projects, maybe there is a good reason for it... but it seems to work fine here.

    ```
    $ grep default= configure.ac
    AC_ARG_ENABLE([ipaccess-utils], [AS_HELP_STRING([--enable-ipaccess-utils], [Build ipaccess utils: abisip-find, ipaccess-config, ... [default=yes]])],
    AC_ARG_ENABLE([meas-udp2db], [AS_HELP_STRING([--enable-meas-udp2db], [Build osmo-meas-udp2db: listen to meas_feed on UDP and write it to an sqlite3 database [default=no]])],
    AC_ARG_ENABLE([meas-pcap2db], [AS_HELP_STRING([--enable-meas-pcap2db], [Build osmo-meas-pcap2db: read PCAP file with meas_feed data and write it to an sqlite3 database [default=no]])],
    AC_ARG_ENABLE([meas-vis], [AS_HELP_STRING([--enable-meas-vis], [Build meas_vis: curses-visualization of measurements [default=no]])],
                                 [enable code coverage support [default=no]]),
                                    [Include the VTY/CTRL tests in make check [default=no]]),
                    [Generate manual PDFs [default=no]],
    ```

To view, visit change 33678. To unsubscribe, or for help writing mail filters, visit settings.