Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27222 ) Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... Patch Set 5: (1 comment) File include/osmocom/pfcp/Makefile.am: https://gerrit.osmocom.org/c/osmo-upf/+/27222/comment/823d1c37_8d7307a5 PS3, Line 17: pfcp_ies_auto.h: $(top_srcdir)/src/libosmo-pfcp/gen__pfcp_ies_auto.c \ I'm not a Makefile guru so no idea, I just noticed that you use it in "$(MAKE) -C $(top_builddir)/src/libosmo-tlv" below, so that buildir must already be created before using it, otherwise it may race. I'm saying exactly because I saw the <<"$(MAKE) -C ..." below.>>. That's not a dependency but the action to be done. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 5 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 17 Mar 2022 18:24:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment