Change in osmo-bsc-nat[master]: bsc_nat_print_addr: handle NULL

Attention is currently required from: osmith, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28581 ) Change subject: bsc_nat_print_addr: handle NULL ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28581/comment/16565131_c1d3e69d PS1, Line 101: if (!addr) { This case doesn't make much sense imho. I'd simply assert or return NULL (printing NULL string is fine in most cases). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I37cfc7ae32d85142d73b523b2f13b94a0bffba7a Gerrit-Change-Number: 28581 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 13:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment