Attention is currently required from: fixeria.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/31850 )
Change subject: virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63)
......................................................................
Patch Set 2:
(2 comments)
File src/host/virt_phy/src/virt_prim_data.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5003):
https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/cbbbd7a2_b0af730b
PS2, Line 81: uint8_t rxlev, uint8_t num_biterr, uint8_t fire_crc)
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5003):
https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/c8fd4528_f8e5db8c
PS2, Line 81: uint8_t rxlev, uint8_t num_biterr, uint8_t fire_crc)
please, no spaces at the start of a line
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/31850
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I4f2982cd8fa1b7a47f983c9cd11bf0180f7878ec
Gerrit-Change-Number: 31850
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 12 Mar 2023 12:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment