Attention is currently required from: fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/31023
)
Change subject: pcu_l1_if: ignore frame numbers that exceed the valid range
......................................................................
Patch Set 7:
(1 comment)
File src/pcu_l1_if.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31023/comment/10e5e5e1_7ef8fd0d
PS2, Line 627: if (rach_ind->fn > GSM_TDMA_HYPERFRAME - 1)
I would also use OSMO_UNLIKELY here.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31023
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib0cf1738be07733c95fc6c459a8a7c4cb2eeef26
Gerrit-Change-Number: 31023
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Feb 2023 12:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment