Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 )
Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
What? It's there. Next line after the 'Change-Id'.
my bad, sorry. I would usually have expected it above the Change-Id and hence my brain stopped parsing at that line :(
File src/osmo-bsc/system_information.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/d3a17f61_83061227 PS1, Line 508: && bts->c0->arfcn >= 1 && bts->c0->arfcn <= 124) : pgsm = true;
This is also an option, yes. […]
I think it's confusing that we have a variable whether or not we are in the PGSM case, but it is true even in a non-PGSM case.