Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30613 )
Change subject: layer23: fix rx_l1_sim_conf(): msg->l2h is NULL, use msg->l1h
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/host/layer23/src/common/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30613/comment/13dee7dc_ef434020
PS1, Line 742: LOGP(DL1C, LOGL_INFO, "SIM %s\n", osmo_hexdump(data, len));
Independent of this patch, I think it's really worth having a special case inside
osmo_hexdump to print "(null)" if the pointer is NULL. What do you think? do
you want to submit it?
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30613
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7c68a3ad393be5fd0413e00e119a06db59672357
Gerrit-Change-Number: 30613
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 11:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment