Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792 )
Change subject: ranap_rab_ass: add decoder and rewrite functions for RAB-AssignmentRequest/Response ......................................................................
Patch Set 15:
(1 comment)
File src/osmo-hnbgw/ranap_rab_ass.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/comment/a1fb5259_7ac9e0c0 PS14, Line 198: int ranap_rab_ass_req_extract_inet_addr(struct osmo_sockaddr *addr, uint8_t *rab_id, RANAP_RANAP_PDU_t *ranap_pdu)
As I stated, the best would likely be to use ranap_message which is an overall container for the RAN […]
When I understand the implementation correctly we only have decoders for the RNC->CN direction yet. (ranap_common_cn.c). This means using the ranap_cn_rx_co() for decoding messages from the RNC would already work. What we do not have yet is a counterpart that can decode CN->RNC messages. We basically need a ranap_common_rnc.c that works the same way as ranap_common_cn.c. At the moment we would only implement the path for the RAB AssignmentRequest (Initiating Message).
I would now start using ranap_common_cn.c for the RAB AssignmentResponse as there the decoder already exist and then implement the decoders and use them for RAB AssignmentRequest.