Attention is currently required from: arehbein.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31972
)
Change subject: gsm_bts_check_ny1: Prevent possible division by zero
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/net_init.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31972/comment/a5d1a05a_704f0c20
PS2, Line 39: { .T = 3105, .default_val = GSM_T3105_DEFAULT, .min_val = 1,
Please better keep it at one line per timer. If at all, move the desc to its own line
only.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31972
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1fd0b92ab507a58fed6e9649eaa4770f1ad1cbad
Gerrit-Change-Number: 31972
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Mar 2023 16:45:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment