[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

Attention is currently required from: fixeria, pespin. csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/14786196_8bbc7b57?usp… : PS3, Line 617: { 0x01, "BCF" }, /* Base Control Function */ I assume you would like to see something like in abis_om2000.c To be honest it would be nice to rewrite the whole Nokia part like the Ericsson code base, but it would take an awful lot of time, and likely better C skills than mine. So I kindly ask you to recommend something that is a littlebit less daunting and preferably already present in the code. The goal is to add the missing but necessary attributes and make the state handling a bit more resilient (and up to the spec.). Only a 2-3 attributes are left for that (besides this). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 3 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 20:52:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>