17 Feb
2025
17 Feb
'25
10:28 a.m.
Attention is currently required from: daniel, lynxis lazus, neels.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )
Change subject: vlr: add PS support ......................................................................
Patch Set 8:
(1 comment)
File src/libvlr/vlr_lu_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/9151b9a6_448cfc64?usp=... : PS5, Line 1437: static void lu_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state)
i agree with pau here because it is only one FSM state's onenter action
This was not yet addressed...
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0
Gerrit-Change-Number: 38490
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Mon, 17 Feb 2025 10:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: lynxis lazus lynxis@fe80.eu