Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27707 )
Change subject: Initialize MGW pool on start up
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
It would be great adding some VTY unit tests (.vty
files).
IMO, VTY commands registered from a library should not be tested in projects
using them. Instead, they should be tested in the library itself. This way we avoid
failures when e.g. a command gets deprecated or its syntax gets extended.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27707
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I6030a1f5a9d5fb06f148b2a2e03ae57bcb6b3766
Gerrit-Change-Number: 27707
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Apr 2022 21:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment