10 Apr
2025
10 Apr
'25
7:03 p.m.
Attention is currently required from: daniel, laforge, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email )
Change subject: ipa: Try picking unused asp_id in AS to use as SLS ......................................................................
Patch Set 1:
(1 comment)
File src/xua_asp_fsm.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003/comment/ba5e70c9_cff9af... : PS1, Line 1119: for (unsigned i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { I am wondering if we can optimize this a bit by calculating a bitmask of used ASP IDs first? You could then quickly do `mask & (1 << asp_id)` to check if it's used or free.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I723eac25e59002630dca87a738c8eb7c62edec75
Gerrit-Change-Number: 40003
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Thu, 10 Apr 2025 17:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No