Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33325 )
Change subject: Forbid partial VTY configurations of ASPs with name asp-clnt-* ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/sigtran/osmo_ss7.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/33325/comment/b51ecdae_20be1fe5 PS2, Line 433: bool role_set_by_vty;
This looks like a public API, and you're adding stuff at the middle of a public struct?
1- Here I'm just readding some fields which used to be there. 2- These fields (.cfg) are basically set by VTY code which is also inside libosmo-sccp. Furthermore the ASP objects are allocated internally so there's no problem with struct size changing.