Attention is currently required from: neels, msuraev.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/29695 )
Change subject: msc_a,vlr: add ciphering_required (accurately named)
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/libvlr/vlr_lu_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/29695/comment/6b71d232_2963348d
PS1, Line 1479: bool try_ciphering,
Comment explaining the difference between
try_ciphering and ciphering_required would be helpful: it' […]
I think the
variable/argument names are rather clear (now)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/29695
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I52090c5f5db997030da7c2ed9beca9c51f55f4cf
Gerrit-Change-Number: 29695
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Oct 2022 10:37:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment