Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/35782?usp=email )
Change subject: rlcmac: Add new structure to allow passing FN+TN to TBF handling
functions
......................................................................
Patch Set 1:
(2 comments)
File src/rlcmac/rlcmac.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/35782/comment/33b78a24_c089fed9
PS1, Line 775: (struct gprs_rlcmac_dl_block_ind *)
`talloc_zero` is a macro, which does pointer cast for
you, so this is not needed […]
weird, I remember adding the case because I got a
warning.
https://gerrit.osmocom.org/c/libosmo-gprs/+/35782/comment/3bc62faf_1e19b27c
PS1, Line 778: OSMO_ASSERT(dlbi);
You already dereferenced `dlbi` above, so assert()ing
makes no sense. […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/35782?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ifa09cd70c915aa3a2b799412cb02315aaebc0503
Gerrit-Change-Number: 35782
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Feb 2024 22:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment