Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email )
Change subject: gsm48_cc_tx_setup_set_bearer_cap: split out ......................................................................
Patch Set 2:
(4 comments)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/7453c33a_e46c78f2?usp=... : PS1, Line 918: static int gsm48_cc_tx_setup_set_bearer_cap(struct gsm_trans *trans, const struct gsm_mncc *setup,
Ack. […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/d0a6fc2f_03297e36?usp=... : PS1, Line 945: rc
`rc` is set but not used here
Done
https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/eea0410a_7670ff2a?usp=... : PS1, Line 971: rc
`rc` is set but not used here
Done
https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/2f84f9fb_a1fba147?usp=... : PS1, Line 1008: rc = gsm48_cc_tx_setup_set_bearer_cap(trans, setup, &bearer_cap);
(trans, &bearer_cap, setup)
Done