10 Oct
2023
10 Oct
'23
1:02 p.m.
Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34697?usp=email )
Change subject: transport: do not catch exceptions in init_reader ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
Patchset:
PS1: You also need to revisit all the callers of this function and remove checking the returned value against `None`.
File pySim/transport/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/34697/comment/820824d2_7fd9f482 PS1, Line 295: Optional no more `Optional`
https://gerrit.osmocom.org/c/pysim/+/34697/comment/37749619_b883fcb3 PS1, Line 299: sl = None # type : :Optional[LinkBase] not needed anymore
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34697?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4c4807576fe63cf71a7d33b243a3f8fea0b7ff23
Gerrit-Change-Number: 34697
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 10 Oct 2023 11:02:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment