Attention is currently required from: neels, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/29864
)
Change subject: mgw: rx_rtp(): reorder checks and handlings
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-mgw/+/29864/comment/27a66f10_a3a65af8
PS1, Line 9: Let's first validate the origin of the message, then the content of the
I'd say the imperative form is specially useful in
the first line since it needs to be short. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/29864
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I011a6d7d705768c32a35cec5cd7169725a21a670
Gerrit-Change-Number: 29864
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Oct 2022 09:23:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment