[S] Change in pysim[master]: ara_m: use class byte of current lchan

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email ) Change subject: ara_m: use class byte of current lchan ...................................................................... Patch Set 5: Code-Review-1 (4 comments) File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/37840/comment/2ea2afe6_b17be3f1?usp=em… : PS5, Line 113: apply_lchan:bool = True Unused in this function? https://gerrit.osmocom.org/c/pysim/+/37840/comment/6914c269_37353c44?usp=em… : PS5, Line 124: pdu = self.cla4lchan(pdu[0:2]) + pdu[2:] ... so you apply even if `apply_lchan == False`? https://gerrit.osmocom.org/c/pysim/+/37840/comment/b5f0f8bd_57833410?usp=em… : PS5, Line 130: apply_lchan:bool = True Unused in this function? https://gerrit.osmocom.org/c/pysim/+/37840/comment/e06e14f5_0b9fa5b2?usp=em… : PS5, Line 178: apply_lchan:bool = True Maybe move this param to the constructor and set `self.apply_lchan`? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 Gerrit-Change-Number: 37840 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 20:10:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes