Attention is currently required from: dexter, laforge.

Patch set 5:Code-Review -1

View Change

4 comments:

• File pySim/commands.py:

  • Patch Set #5, Line 113: apply_lchan:bool = True

    Unused in this function?

  • Patch Set #5, Line 124: pdu = self.cla4lchan(pdu[0:2]) + pdu[2:]

    ... so you apply even if `apply_lchan == False`?

  • Patch Set #5, Line 130: apply_lchan:bool = True

    Unused in this function?

  • Patch Set #5, Line 178: apply_lchan:bool = True

    Maybe move this param to the constructor and set `self.apply_lchan`?

To view, visit change 37840. To unsubscribe, or for help writing mail filters, visit settings.