Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/35924?usp=email )
Change subject: csd_v110: use osmo_csd_chan_mode_rate_desc[] from libosmogsm
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/common/csd_v110.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35924/comment/d36ac669_2bded9fc
PS1, Line 37: if 0
: [GSM48_CMODE_DATA_14k5] = {
: /* TCH/F14.4: 290 bits every 20 ms (14.5 kbit/s) */
: .fr = { .num_blocks = 1, .num_bits = 290 },
: },
: #endif
to contrast my comment about l ibosmocore: here I don't object the table, as it's
a local definition of an application.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/35924?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1e16a1f8142ff3cf0e26e16316fde4c42082ad54
Gerrit-Change-Number: 35924
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 10 Feb 2024 08:20:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment