27 Jul
2023
27 Jul
'23
9:38 p.m.
Attention is currently required from: dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33954 )
Change subject: utils: tolerate uninitialized fields in dec_addr_tlv ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File pySim/utils.py:
https://gerrit.osmocom.org/c/pysim/+/33954/comment/0f1a4c70_f2321bb3 PS1, Line 775: if tlv[2] == [0xff] * len(tlv[2]): Not critical: I would recommend doing `if all([v == 0xff for v in tlv[2]]):`, as it's more self-explaining IMO. Related: https://stackoverflow.com/questions/3525953/check-if-all-values-of-iterable-....
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idc0a92ea88756266381c8da2ad62de061a8ea7a1
Gerrit-Change-Number: 33954
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 27 Jul 2023 19:38:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment