27 Nov
2023
27 Nov
'23
12:42 p.m.
Attention is currently required from: falconia, fixeria.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email )
Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH
......................................................................
Patch Set 2:
(5 comments)
File src/osmo-bts-trx/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/8e4e8c42_d939e1b8
PS1, Line 550: FIXME: someone who knows AMR needs to look at this problem
: * and decide what is the correct BTS Tx behavior for frame
: * gaps in TCH/AFS. See OS#6049.
This block can now be removed?
Done
https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/5a523759_b747285f
PS1, Line 571: goto send_burst
Similarly to how it's done below for
`gsm0503_tch_fr_encode()`, let's check the returned value. […]
Done
File src/osmo-bts-trx/sched_lchan_tchh.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/01d8d64c_6b39561c
PS1, Line 453: TCH/HS
Mention TCH/AHS here? Or add a separate bullet point,
like you did in `tx_tchf_fn()`?
Done
https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/0e95314a_dd052b60
PS1, Line 462: FIXME: someone who knows AMR needs to look at this problem
: * and decide what is the correct BTS Tx behavior for frame
: * gaps in TCH/AHS. See OS#6049.
Likewise, can be removed.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/fe2f06a8_ebaab58a
PS1, Line 474: gsm0503_tch_ahs_encode
Same here, we need to check returned value.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3
Gerrit-Change-Number: 35132
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Nov 2023 11:42:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment