Attention is currently required from: falconia, fixeria.

View Change

5 comments:

• File src/osmo-bts-trx/sched_lchan_tchf.c:

  • Patch Set #1, Line 550:

    FIXME: someone who knows AMR needs to look at this problem
    		 * and decide what is the correct BTS Tx behavior for frame
    		 * gaps in TCH/AFS.  See OS#6049.
    

    This block can now be removed?

    Done

  • Patch Set #1, Line 571: goto send_burst

    Similarly to how it's done below for `gsm0503_tch_fr_encode()`, let's check the returned value. […]

    Done

• File src/osmo-bts-trx/sched_lchan_tchh.c:

  • Patch Set #1, Line 453: TCH/HS

    Mention TCH/AHS here? Or add a separate bullet point, like you did in `tx_tchf_fn()`?

    Done

  • Patch Set #1, Line 462:

    FIXME: someone who knows AMR needs to look at this problem
    		 * and decide what is the correct BTS Tx behavior for frame
    		 * gaps in TCH/AHS.  See OS#6049.
    

    Likewise, can be removed.

    Done

  • Patch Set #1, Line 474: gsm0503_tch_ahs_encode

    Same here, we need to check returned value.

    Done

To view, visit change 35132. To unsubscribe, or for help writing mail filters, visit settings.