Attention is currently required from: fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email )
Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ......................................................................
Patch Set 3:
(4 comments)
File configure.ac:
https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/8887d85c_e3ee174c?usp... : PS3, Line 65: dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang
put the configure.ac and . […]
Well they start to be needed here since I'm adding unit tests for the feature I'm adding, I think it makes sense to have it here.
File src/osmo_server_network.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/816682d3_352d8f98?usp... : PS3, Line 231: /* Checks if we are in a new record period since last time we wrote to a pcap, to know (return true) whether a new pcap file needs to be opened.
cosmetic: very long line
Acknowledged
File src/osmo_server_vty.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/a316200e_85782104?usp... : PS3, Line 219: frecuency
frequency
Acknowledged
https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/e236778c_3498c22d?usp... : PS3, Line 246: max_mod = 4294967295;
(that will take a while :D) […]
We cannot use it easily in DEFUN since stringifying it then adds eg. "UL" at the end. I think it doesn't really matter in this case, take it as simply a big enough year :)