Attention is currently required from: Hoernchen, laforge, osmith.
pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email )
Change subject: octsim: initial commit ......................................................................
Patch Set 4:
(6 comments)
File octsim/OCTSIM_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/7fc8dc30_02cf4... : PS4, Line 22: //USB_Device_Match mp_usb_dev_match := { vid_pid := { vid := '1d50'H, pid := '60e3'H} }; can this be dropped?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/cb08642c_22ef5... : PS4, Line 36: private template (value) USB_IF_Params ts_UsbPars_path(charstring path, uint8_t if_nr) := { shouldn't this go into USB_Templates.ttcn?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/e612b18c_54d76... : PS4, Line 74: //activate(as_Tguard); would be great to have Tguard working from the first commit...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/ca7413ce_5861c... : PS4, Line 81: function f_st_drain() runs on test_CT { what's the purpose of this function? I think it requires some documentation. Perhaps simply calling ST.clear() would be the right thing?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/bf643089_d34f8... : PS4, Line 110: setverdict(fail, "Timeout waiting for ", exp_rx); FYI we have Misc_Helpers.f_shutdown() to make sure everything is shutdown properly.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/1d15528e_184fd... : PS4, Line 191: testcase TC_test() runs on test_CT can we name this with a more specific scenario?