Attention is currently required from: Hoernchen, laforge, osmith.

View Change

6 comments:

• File octsim/OCTSIM_Tests.ttcn:

  • Patch Set #4, Line 22: //USB_Device_Match mp_usb_dev_match := { vid_pid := { vid := '1d50'H, pid := '60e3'H} };

    can this be dropped?

  • Patch Set #4, Line 36: private template (value) USB_IF_Params ts_UsbPars_path(charstring path, uint8_t if_nr) := {

    shouldn't this go into USB_Templates.ttcn?

  • Patch Set #4, Line 74: //activate(as_Tguard);

    would be great to have Tguard working from the first commit...

  • Patch Set #4, Line 81: function f_st_drain() runs on test_CT {

    what's the purpose of this function? I think it requires some documentation.
    Perhaps simply calling ST.clear() would be the right thing?

  • Patch Set #4, Line 110: setverdict(fail, "Timeout waiting for ", exp_rx);

    FYI we have Misc_Helpers.f_shutdown() to make sure everything is shutdown properly.

  • Patch Set #4, Line 191: testcase TC_test() runs on test_CT

    can we name this with a more specific scenario?

To view, visit change 27341. To unsubscribe, or for help writing mail filters, visit settings.