Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31632
to look at the new patch set (#2).
Change subject: tweak gsm_pchan_ids[]: s/OSMO_DYN/OSMODYN ......................................................................
tweak gsm_pchan_ids[]: s/OSMO_DYN/OSMODYN
This patch affects *only* on osmo_fsm instance IDs, which are visible on the CTRL and VTY interfaces to identify FSM instances, and in the log.
Why bother: An upcoming patch wants to replace gsm_pchan_ids[] with osmo_fsm_inst_update_id_f_sanitize(gsm_pchan_name(x)), this is an explicit step to match gsm_pchan_names[].
Why drop the underscore: On the VTY, in phys_chan_config names, there commonly is an underscore separator to indicate that a timeslot can become either of the parts, e.g. TCH/F_PDCH means the timeslot can be TCH/F, or it can be PDCH. The name "OSMO_DYN" would then imply that it can be either OSMO, or DYN, so let's rather name it OSMODYN.
Change-Id: I4a540744cced466f0ca4fc605db4d0ec14ee8e87 --- M TODO-RELEASE M src/osmo-bsc/gsm_data.c M tests/bsc/bsc_test.ok 3 files changed, 27 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/31632/2