Change in osmo-upf[master]: fix access/core mixup of PDR IDs / tunmap FAR

Attention is currently required from: arehbein. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30466 ) Change subject: fix access/core mixup of PDR IDs / tunmap FAR ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: (actually it ended up https://gerrit.osmocom.org/c/osmo-upf/+/30460 being squashed into this patch) PS1: re renaming, that would have to be a separate patch. i see a potential for confusion with 'pdr_at_core' and 'far_at_core'. In PFCP, a PDR is linked to a FAR, and it is 'pdr_at_core' linked to 'far_at_access' and vice versa. I prefer to have a similarity between the names of the PDR+FAR linked together, to match the semantics in PFCP. So I chose pdr+far and rpdr+rfar with r meaning reverse. true, if it were more verbose there could be less documentation. i'd see pdr_access_to_core + far_acces_to_core and pdr_core_to_access + far_core_to_access but they are so much longer. pdr_a2c + far_a2c and pdr_c2a + far_c2a ? if you insist i could change that -- but in a separate patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I66babdfe4c1746bd3bf259342ce80dae2661de8c Gerrit-Change-Number: 30466 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Dec 2022 05:18:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: comment