Attention is currently required from: dexter, neels.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38014?usp=email )
Change subject: pySim.esim.saip: Implement optimized file content encoding ......................................................................
Patch Set 6:
(2 comments)
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/38014/comment/27bf2d19_6aa2f9e9?usp=ema... : PS6, Line 61: assert match.a >= cur
maybe return also return a ValueError? (The caller does not have to check for the ValueError and rai […]
Done
https://gerrit.osmocom.org/c/pysim/+/38014/comment/f8d738cf_a5e14c4e?usp=ema... : PS6, Line 463: ret.append(('fillFileOffset', block.a - cur))
cur is set to 0 at the beginning but it does not get re-assigned. […]
thanks, I fixed it in the next version.