Attention is currently required from: laforge.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35073?usp=email )
Change subject: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd() ......................................................................
Patch Set 1: Code-Review-1
(4 comments)
Patchset:
PS1: -1 because of #915
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35073/comment/3658ad5a_96729220 PS1, Line 738: rc = ipa_msg_recv_buffered(ofd->fd, &msg, &asp->pending_msg); I think `if (fd < 0) ...` like above would be good here
https://gerrit.osmocom.org/c/libosmo-sccp/+/35073/comment/9934344f_dd3d0b62 PS1, Line 846: asp->sock_name = osmo_sock_get_name(asp, fd); `osmo_sock_get_name_buf()` (which will be called) does check for `fd < 0`, not sure if we also want to check here in advance
https://gerrit.osmocom.org/c/libosmo-sccp/+/35073/comment/36d319ed_3dbeb89a PS1, Line 915: return ipa_rx_msg(asp, msg, fd & 0xf); probably very problematic without a check `if (fd < 0)` ...?