Attention is currently required from: laforge.

Patch set 1:Code-Review -1

View Change

4 comments:

• Patchset:

  • Patch Set #1:

    -1 because of #915

• File src/osmo_ss7_asp.c:

  • Patch Set #1, Line 738: rc = ipa_msg_recv_buffered(ofd->fd, &msg, &asp->pending_msg);

    I think `if (fd < 0) ...` like above would be good here

  • Patch Set #1, Line 846: asp->sock_name = osmo_sock_get_name(asp, fd);

    `osmo_sock_get_name_buf()` (which will be called) does check for `fd < 0`, not sure if we also want to check here in advance

  • Patch Set #1, Line 915: return ipa_rx_msg(asp, msg, fd & 0xf);

    probably very problematic without a check `if (fd < 0)` ...?

To view, visit change 35073. To unsubscribe, or for help writing mail filters, visit settings.