Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27248 )
Change subject: rename RSL_ENC_ALG_A5 to ALG_A5_NR_TO_RSL, clarify ......................................................................
Patch Set 2:
(2 comments)
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/27248/comment/c592e448_e6a342ea PS2, Line 542: none = -1 here, negative
https://gerrit.osmocom.org/c/osmo-bsc/+/27248/comment/523c31c7_f1beb164 PS2, Line 546: (A5_N) >= 0
Why this check? Do we really use negative numbers in this context?
true, that for -1 the condition would not be needed. But since we're in a habit of passing -ERRNO we might as well rather interpret all negatives as "no algo found"