Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email )
Change subject: add osmo_pfcp_ip_addrs_get
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-pfcp/pfcp_msg.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348/comment/ba463341_162c07fa
PS1, Line 523: *v4 = (struct osmo_sockaddr){};
you probably want to set sa_family to AF_UNSPEC here.
[…]
i doubt that it's needed, but simple enough.
BTW for the sockaddr_str below it suffices to have .ip[0] == 0.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I4338a83f26ef2443f90cf835621e73aed5eac521
Gerrit-Change-Number: 36348
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Mar 2024 12:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment