Change in libosmo-gprs[master]: rmcmac: Refactor msg_type enums and value_string

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rmcmac: Refactor msg_type enums and value_string ...................................................................... Patch Set 1: (83 comments) File include/osmocom/gprs/rlcmac/types.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/8b9b4395_2c4e8a5a PS1, Line 89: extern const struct value_string osmo_gprs_rlcmac_ul_msg_type_names[]; adding a line without newline at end of file File src/rlcmac/csn1_ts_44_060.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/833366ea_43e3a43a PS1, Line 4439: msg_type_name = get_value_string(osmo_gprs_rlcmac_ul_msg_type_names, data->u.MESSAGE_TYPE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/2cd9f856_36fe96ff PS1, Line 4444: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CELL_CHANGE_FAILURE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/d72121b0_a9b5ded1 PS1, Line 4454: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CONTROL_ACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/429b513e_bb00b521 PS1, Line 4459: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_DOWNLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/7dd720d7_a7159fa1 PS1, Line 4464: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_UPLINK_DUMMY_CONTROL_BLOCK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/0e43f3e8_ab1fe6ca PS1, Line 4469: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_MEASUREMENT_REPORT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/92154ab1_2df3e68c PS1, Line 4474: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_RESOURCE_REQUEST: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/01454fc7_c51556cb PS1, Line 4480: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_MOBILE_TBF_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/760cef11_31313594 PS1, Line 4485: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_PSI_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/a68361ff_b831529a PS1, Line 4490: case OSMO_GPRS_RLCMAC_UL_MSGT_EGPRS_PACKET_DOWNLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/5a79c765_2ec4cfd2 PS1, Line 4495: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_PAUSE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/c535fb7f_d6cf25c5 PS1, Line 4500: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_ENHANCED_MEASUREMENT_REPORT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/9fcf3090_22c1ecdd PS1, Line 4505: case OSMO_GPRS_RLCMAC_UL_MSGT_ADDITIONAL_MS_RAC: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/bf1425e0_f5f5e514 PS1, Line 4510: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CELL_CHANGE_NOTIFICATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/40b345d6_b25ecb08 PS1, Line 4515: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_SI_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/63296b45_1351d5a4 PS1, Line 4601: msg_type_name = get_value_string(osmo_gprs_rlcmac_dl_msg_type_names, data->u.MESSAGE_TYPE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/436e3298_021f72d4 PS1, Line 4607: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_ACCESS_REJECT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/0c5ffc4d_1b35b8f0 PS1, Line 4612: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_CELL_CHANGE_ORDER: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/4b87c89a_dea4a313 PS1, Line 4617: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_CELL_CHANGE_CONTINUE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/a0a5fe0e_c1c4748e PS1, Line 4622: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_ASSIGNMENT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/bac257b8_c0de4e7a PS1, Line 4627: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_MEASUREMENT_ORDER: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/f2608678_55be15f2 PS1, Line 4632: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_NEIGHBOUR_CELL_DATA: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/4f887f51_a973b7ed PS1, Line 4637: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SERVING_CELL_DATA: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b9bf1b14_ba6566e7 PS1, Line 4642: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PAGING_REQUEST: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/274f8b8d_8dcb7356 PS1, Line 4647: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PDCH_RELEASE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/498efae3_1b557335 PS1, Line 4652: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_POLLING_REQ: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/419e5614_7034e552 PS1, Line 4657: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_POWER_CONTROL_TIMING_ADVANCE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/39324211_013a8288 PS1, Line 4662: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PRACH_PARAMETERS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/a5c3caf5_62722521 PS1, Line 4667: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_QUEUEING_NOTIFICATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b3dfd094_7e32376e PS1, Line 4672: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_TIMESLOT_RECONFIGURE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/f8d14a27_ff9a726e PS1, Line 4677: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_TBF_RELEASE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/f3e4fbf4_8e7c9179 PS1, Line 4682: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b3772b3f_795ec725 PS1, Line 4687: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ASSIGNMENT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/03f8b412_84ce97f7 PS1, Line 4692: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_HANDOVER_COMMAND: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/730c78b9_b996e533 PS1, Line 4697: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PHYSICAL_INFORMATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/7e96382a_1fe8202a PS1, Line 4702: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/e78c8e6b_f6f89afb PS1, Line 4707: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_1: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/9ad5d458_096acf9c PS1, Line 4712: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_2: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/0044251d_f86a321d PS1, Line 4717: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_3: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1d550b65_9cece7d5 PS1, Line 4722: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_5: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/e452d73a_c60db289 PS1, Line 4727: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_13: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/67e671a9_172b6529 PS1, Line 4762: msg_type_name = get_value_string(osmo_gprs_rlcmac_ul_msg_type_names, data->u.MESSAGE_TYPE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/ef06f346_bca9e42d PS1, Line 4767: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CELL_CHANGE_FAILURE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/aaae3311_64a4ef99 PS1, Line 4777: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CONTROL_ACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/71502892_8c461334 PS1, Line 4782: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_DOWNLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/d1f2b508_f8953fdf PS1, Line 4787: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_UPLINK_DUMMY_CONTROL_BLOCK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/48d9b2b5_ffa61181 PS1, Line 4792: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_MEASUREMENT_REPORT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/7df40cd0_84662736 PS1, Line 4797: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_RESOURCE_REQUEST: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/5e066290_9dadeb5c PS1, Line 4803: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_MOBILE_TBF_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/ec13df23_f225dae2 PS1, Line 4808: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_PSI_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/34a53cac_2df833ca PS1, Line 4813: case OSMO_GPRS_RLCMAC_UL_MSGT_EGPRS_PACKET_DOWNLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1c471ca2_43b17dfd PS1, Line 4818: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_PAUSE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1b2bd753_fdc00516 PS1, Line 4823: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_ENHANCED_MEASUREMENT_REPORT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/4cbaff0c_c6e580f9 PS1, Line 4828: case OSMO_GPRS_RLCMAC_UL_MSGT_ADDITIONAL_MS_RAC: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/8bb40eb1_0ffb3938 PS1, Line 4833: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_CELL_CHANGE_NOTIFICATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/0d34a5c1_806e707f PS1, Line 4838: case OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_SI_STATUS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/83ab1723_b7fe8003 PS1, Line 4923: msg_type_name = get_value_string(osmo_gprs_rlcmac_dl_msg_type_names, data->u.MESSAGE_TYPE); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/1803f938_048ffead PS1, Line 4928: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_ACCESS_REJECT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/72dcdda0_fdc8c646 PS1, Line 4933: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_CELL_CHANGE_ORDER: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/43445995_eaed8013 PS1, Line 4938: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_CELL_CHANGE_CONTINUE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/d48176ab_0b730557 PS1, Line 4943: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_ASSIGNMENT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/7bb87b98_2a067bb6 PS1, Line 4948: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_MEASUREMENT_ORDER: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/7ccd708c_0ebb736b PS1, Line 4953: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_NEIGHBOUR_CELL_DATA: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/7cea8e9b_6eb8c0e5 PS1, Line 4958: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SERVING_CELL_DATA: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b47043de_ed52bad8 PS1, Line 4963: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PAGING_REQUEST: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/d4a89c5e_d18749cc PS1, Line 4968: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PDCH_RELEASE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/fea0c9ad_4be0c2a1 PS1, Line 4973: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_POLLING_REQ: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/998b82cc_ab130377 PS1, Line 4978: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_POWER_CONTROL_TIMING_ADVANCE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/9b7993b0_9a9af42c PS1, Line 4983: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PRACH_PARAMETERS: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/84881f09_4dd67aba PS1, Line 4988: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_QUEUEING_NOTIFICATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/ca672627_59378a5f PS1, Line 4993: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_TIMESLOT_RECONFIGURE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/4e6c0868_bc78334b PS1, Line 4998: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_TBF_RELEASE: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/0ce24b45_47686aab PS1, Line 5003: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ACK_NACK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/f03b2056_92eb061b PS1, Line 5008: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ASSIGNMENT: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/16c2452a_7be3b63a PS1, Line 5013: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_HANDOVER_COMMAND: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/9487cdd6_c102cdbc PS1, Line 5018: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_PHYSICAL_INFORMATION: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/faa1375c_0fc0d214 PS1, Line 5023: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/73957ff1_31ab6ddb PS1, Line 5028: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_1: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/8f8c20fb_32d359ef PS1, Line 5033: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_2: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/28ca0fc1_4264c323 PS1, Line 5038: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_3: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/edf1b758_83d502cb PS1, Line 5043: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_5: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3190): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/68957dc5_65c949dc PS1, Line 5048: case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_SYSTEM_INFO_13: please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 01 Feb 2023 16:23:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment