Attention is currently required from: daniel, fixeria, pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email )
Change subject: ipaccess: Convert BSC OML & RSL link to use stream_srv
......................................................................
Patch Set 4:
(3 comments)
File src/input/ipaccess.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/6a6b46f6_679f54b2… :
PS4, Line 387: ballback
callback
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/a8b77763_b34c999c… :
PS4, Line 470: default:
maybe put a log msg here?
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/62ef51f2_327840c9… :
PS4, Line 705: /* PESPIN: TODO: use osmo_stream_srv_send() instead */
did you leave this TODO intentionally?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Idf241c8f2fdb86d090d4132a9b316b7236402232
Gerrit-Change-Number: 38983
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Dec 2024 10:32:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No