Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27392 )
Change subject: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_translate() ......................................................................
Patch Set 2:
(2 comments)
File src/libosmo-mgcp/mgcp_codec.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/27392/comment/ba7aaa45_62231ef0 PS1, Line 369: static bool codecs_same(struct mgcp_rtp_codec *codec_a, struct mgcp_rtp_codec *codec_b, bool match_pload_fmt)
I'd make this more generic: bool allow_transcoding […]
I don't think that this is good. I would find this parameter naming very confusing. Also its not really about transcoding (one codec into another). Its more about format conversion.
https://gerrit.osmocom.org/c/osmo-mgw/+/27392/comment/2607880d_9d21d980 PS1, Line 431: /* In case we weren't able to find an exact match, we will try to find a match that is the same codec, but the
Make all this generic. […]
I do not see where this is not generic. This would work with any codec that supports different payload formats. (codecs_same would need an upgrade though, but that is a different story)