Attention is currently required from: jolly, laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email )
Change subject: 5gc: Support PDU Session Establishment procedure ......................................................................
Patch Set 6:
(5 comments)
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/aa49df74_97aa1... : PS6, Line 324: log("Rx NAS message: ", rx_nas); looks unrelated
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/eb5076ad_845e5... : PS6, Line 386: log("Rx inner NAS: ", rx_nas); looks unrelated
File deps/Makefile:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/3b78cacd_3c2b7... : PS6, Line 74: Do not put references to branches here This has been removed in a recent commit. Looks like a rebase artifact.
File library/NG_NAS_Osmo_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/b143b5e6_e2905... : PS6, Line 584: omit How can the whole template be `omit`? It always yields a `value`, right?
File library/NG_NAS_Osmo_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/6fb53ae4_ab50d... : PS6, Line 70: errorbehavior(ALL:WARNING) Interesting, haven't seen this before. What does it do?