Attention is currently required from: fixeria, fixeria, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email )
Change subject: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2)
......................................................................
Patch Set 3:
(2 comments)
File src/osmo-bts-trx/trx_if.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/7774bd75_2e5857fc
PS3, Line 731: goto rsp_error;
just to confirm, don't we need to reset
`flushed_wile_in_trx_ctrl_read_cb` to `false` here?
Yes, I actually forgot that one,
thanks!.
https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/55832446_86eab842
PS3, Line 738: return 0;
just to confirm, don't we need to reset
`flushed_wile_in_trx_ctrl_read_cb` to `false` here?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df
Gerrit-Change-Number: 32552
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator(a)gmail.com>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <axilirator(a)gmail.com>
Gerrit-Comment-Date: Wed, 25 Oct 2023 13:56:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment