Attention is currently required from: Hoernchen, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/32762 )
Change subject: transceiver: pass cfg struct instead of args
......................................................................
Patch Set 3:
(1 comment)
File Transceiver52M/device/lms/LMSDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/906f6421_8d84008d
PS3, Line 110: LMSDevice(InterfaceType iface, const struct trx_cfg *cfg);
We can either […]
AFAICT, the usual approach we
take in such situations is to reformat once in one patch, and then perform the functional
changes on top of that. I think we've done this in imported C code and in python, not
sure if we did it with C++
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/32762
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I48386900d15ff4d770c70a4efc246d32f921904b
Gerrit-Change-Number: 32762
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Jul 2023 13:02:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment