Attention is currently required from: laforge, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31144
)
Change subject: pcu_sock: transfer E1 connection information to PCU
......................................................................
Patch Set 5:
(2 comments)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/5897dbb0_493a0877
PS1, Line 315: struct gsm_bts_trx_ts *ts;
I agree with fixeria (and I also think it is
long-established general practice in osmocom) to declar […]
Done
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/4c8c33a3_b9e867a6
PS4, Line 326: t
for example ts should be declared here as it's
only used inside the for-loop. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31144
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6d44373336b41009ff4c6e459d32d0a81081676c
Gerrit-Change-Number: 31144
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Feb 2023 14:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment