Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif ......................................................................
Patch Set 5:
(3 comments)
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/4f683d70_f4820a8e... : PS2, Line 157: config->thinning_int = 17;
AFAICT the only similarity between my algorithm and CoDel is that both algos sometimes "artificially […]
Can this point be marked as resolved?
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/792ea0c4_ee9a92a2... : PS3, Line 331: static void analytics_cont(struct osmo_twjit *twjit, uint16_t rx_seq,
Not necessarily in perfect order, just same SSRC. […]
Can this point be marked as resolved?
File src/twjit_vty.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/8911bc55_90e97c78... : PS2, Line 41: vty_out(vty, "%s%s%s", prefix, name ? : "twjit", VTY_NEWLINE);
I think it may be easier having it as total prefix, but not a hard blocker here.
Can this point be marked as resolved?