Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30254 )
Change subject: trxcon: make burst pointer in trxcon_phyif_burst_ind const ......................................................................
Patch Set 1:
(1 comment)
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30254/comment/af7ae5a1_400b9ea1 PS1, Line 658: sbit_t *burst = (sbit_t *)&buf[8];
Ah I see what you mean. […]
To clarify things further:
* This function has a static buffer buf[], which is used for read()ing TRXD datagrams from socket. Obviously, it cannot be const here. * This function needs to convert from usbits to sbits, so within the loop I am casting from (uint8_t *) to (sbit_t *). * The upper layers get (const sbit_t *) via bi->burst.
I can move this *burst outside of the loop if this makes things cleaner.