Change in osmo-pcu[master]: encoding: fix an uninitialized field in gen_freq_params()

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28423 ) Change subject: encoding: fix an uninitialized field in gen_freq_params() ...................................................................... encoding: fix an uninitialized field in gen_freq_params() This is not critical, given that we set 'ElementsOf_RFL_NUMBER' to 0. But still, let's ensure that all fields are initialized. Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c Fixes: CID#272999 --- M src/encoding.cpp 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/encoding.cpp b/src/encoding.cpp index 4737137..f552111 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -573,6 +573,8 @@ fh_params.MAIO = pdch->fh.maio; fh_params.GPRS_Mobile_Allocation.HSN = pdch->fh.hsn; fh_params.GPRS_Mobile_Allocation.ElementsOf_RFL_NUMBER = 0; + memset(&fh_params.GPRS_Mobile_Allocation.RFL_NUMBER[0], 0x00, + sizeof(fh_params.GPRS_Mobile_Allocation.RFL_NUMBER)); /* Mobile Allocation bitmap */ fh_params.GPRS_Mobile_Allocation.UnionType = 0; /* MA bitmap */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c Gerrit-Change-Number: 28423 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged