[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add first ASCI test to check NCH support

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816 ) Change subject: BTS_Test_ASCI: Add first ASCI test to check NCH support ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: a File bts/BTS_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816/comment/600c512b_9222… PS3, Line 107: RSL_CCHAN.send(ts_ASP_RSL_UD(ts_RSL_NOTIF_CMD_STOP(gcr))); : : /* NCH must not be received. */ there is a potential race condition here between the last L1CTL.receive above, and the time you send the NOTIF_CMD_STOP. Another NCH message might be stored in any of the buffers of osmo-bts, the kernel, trxcon, or a TITAN component, and then magically appear below when you no longer expect them. This is the kind of race condition which makes tests fail occasionally and reuslts in ustable test results in jenkins. If there is no confirmation message to the CMD_STOP from the BTS you cannot make assumptions when it will actually arrive and execute. Hence, as a work-around it might be prudent to wait for somehing like 0.5s and then flush any pending L1CTL messages before executing the below code. There might be other solutions, just think about the problem in general and see what you can come up with. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3727c471663b731117a264f60d2f1ba5fd16928e Gerrit-Change-Number: 33816 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment