laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31964 )
Change subject: cosmetic: gsm_pchan2chan_nr(): Update spec documentation ......................................................................
cosmetic: gsm_pchan2chan_nr(): Update spec documentation
Change-Id: If1de230f022c69f3dfce8a7c66d494a984e7f3f9 --- M src/common/lchan.c 1 file changed, 11 insertions(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved
diff --git a/src/common/lchan.c b/src/common/lchan.c index 638f30a..8d2b649 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -322,7 +322,7 @@ } }
-/* See Table 10.5.25 of GSM04.08 */ +/* See 3GPP TS 44.018 Table 10.5.2.5.1 "Channel Description information element" */ static uint8_t gsm_pchan2chan_nr(enum gsm_phys_chan_config pchan, uint8_t ts_nr, uint8_t lchan_nr) { @@ -369,7 +369,7 @@ case GSM_PCHAN_NONE: LOGP(DRSL, LOGL_ERROR, "ts=%u,ss=%u Physical channel %s not expected!\n", ts_nr, lchan_nr, gsm_pchan_name(pchan)); - cbits = 0x00; + cbits = 0x00; /* Reserved */ break; default: LOGP(DRSL, LOGL_ERROR, "ts=%u,ss=%u Physical channel %s (0x%02x) not expected!\n",