Attention is currently required from: laforge, fixeria. Hello Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/30946
to look at the new patch set (#2).
Change subject: gsm_utils: improve gsm_gsmtime2fn() ......................................................................
gsm_utils: improve gsm_gsmtime2fn()
The function gsm_gsmtime2fn() uses a hack to account for the truncated modulo implementation of C/C++. libosmocore offers proven modulo functions, so lets use OSMO_MOD_FLR() instead. Also arange the formula so that it looks more like the one in the spec.
Also add better spec references and a final modulo GSM_MAX_FN to prevent frame number results that exceed the valid range.
Change-Id: Ibf94bca8223f1f7858a6dd67bf27de0ab6feab20 --- M src/gsm/gsm_utils.c 1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/30946/2