Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/39952?usp=email )
Change subject: SMS-over-GSUP: send network-originated MT-forwardSM-Err ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/c/osmo-msc/+/39952/comment/f9e70654_f3f64237?usp=... : PS1, Line 1332: rate_ctr_inc(rate_ctr_group_get_ctr(net->msc_ctrs, MSC_CTR_SMS_DELIVERED)); (as FIXME mentions, this is probably in the wrong place).
https://gerrit.osmocom.org/c/osmo-msc/+/39952/comment/6b023d06_284dabea?usp=... : PS1, Line 1457: } (we may want to add a rate counter for failed deliveries here.)