dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33340 )
Change subject: pcu_sock: use correct SAPI in message PCUIF PCU_IF_MSG_DATA_CNF_DT ......................................................................
pcu_sock: use correct SAPI in message PCUIF PCU_IF_MSG_DATA_CNF_DT
The message PCU_IF_MSG_DATA_CNF_DT uses SAPI PCU_IF_SAPI_PCH, which is formally not correct. It should use SAPI PCU_IF_SAPI_PCH_DT
Depends: osmo-pcu.git I0883b51fc232ec0267f1511c3a37c0bcd0967a08 Change-Id: Id5c799e625c56e57f7b51cd4fb57f5bea9c973d2 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 14 insertions(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve dexter: Looks good to me, approved
diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index 32307ff..8a1d5b0 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -450,7 +450,7 @@ pcu_prim = (struct gsm_pcu_if *) msg->data; data_cnf_dt = &pcu_prim->u.data_cnf_dt;
- data_cnf_dt->sapi = PCU_IF_SAPI_PCH; + data_cnf_dt->sapi = PCU_IF_SAPI_PCH_DT; data_cnf_dt->tlli = tlli;
return pcu_sock_send(bts->network, msg);